Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sentry sampling): reduce by 25% our sentry trace sample rate to avoid exceeding our quota #13745

Merged
merged 1 commit into from
Feb 28, 2025
Merged

fix(sentry sampling): reduce by 25% our sentry trace sample rate to avoid exceeding our quota #13745

merged 1 commit into from
Feb 28, 2025
+1 −1

Conversation

gauthierpetetin
Copy link
Contributor

@gauthierpetetin gauthierpetetin commented Feb 27, 2025 •
edited
Loading

Description

  • Reduce by 25% our sentry trace sample rate to avoid exceeding our quota.

Related issues

Fixes: None

Manual testing steps

  • None

Screenshots/Recordings

  • None

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gauthierpetetin gauthierpetetin added No QA Needed Apply this label when your PR does not need any QA effort. area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. team-mobile-platform Mobile Platform team No E2E Smoke Needed If the PR does not need E2E smoke test run labels Feb 27, 2025
@gauthierpetetin gauthierpetetin self-assigned this Feb 27, 2025
@gauthierpetetin gauthierpetetin requested a review from a team as a code owner February 27, 2025 12:54
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Feb 27, 2025
@gauthierpetetin gauthierpetetin force-pushed the fix/sentry-trace-sample-rate-01 branch from 07ab5fa to 1f51f3a Compare February 27, 2025 18:32
@gauthierpetetin gauthierpetetin changed the title fix(sentry sampling): reduce by 75% our sentry trace sample rate to avoid exceeding our quota fix(sentry sampling): reduce by 25% our sentry trace sample rate to avoid exceeding our quota Feb 27, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gauthierpetetin gauthierpetetin added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit a4052ae Feb 28, 2025
43 checks passed
@gauthierpetetin gauthierpetetin deleted the fix/sentry-trace-sample-rate-01 branch February 28, 2025 19:31
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2025
@metamaskbot metamaskbot added the release-7.43.0 Issue or pull request that will be included in release 7.43.0 label Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

Assignees

@gauthierpetetin gauthierpetetin

Labels
area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.43.0 Issue or pull request that will be included in release 7.43.0 team-extension-platform Extension Platform team team-mobile-platform Mobile Platform team
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gauthierpetetin @tommasini @metamaskbot